Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide ProgressBarTrack in IndeterminateError and IndeterminatePause #4920

Merged
merged 3 commits into from
May 3, 2021
Merged

Hide ProgressBarTrack in IndeterminateError and IndeterminatePause #4920

merged 3 commits into from
May 3, 2021

Conversation

karkarl
Copy link
Contributor

@karkarl karkarl commented Apr 28, 2021 •
edited
Loading

Description

  • Hide ProgressBarTrack in IndeterminateError and IndeterminatePause to match specs
  • Tweak ProgressBarTestPage to be more usable

Screenshots (if appropriate):

Error:
image
Paused:
image

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 28, 2021
@karkarl
Copy link
Contributor Author

karkarl commented Apr 28, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj added area-Progress ProgressBar, ProgressRing area-UIDesign UI Design, styling team-Controls Issue for the Controls team labels Apr 28, 2021
@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Apr 28, 2021
StephenLPeters
StephenLPeters reviewed Apr 29, 2021
View reviewed changes
dev/ProgressBar/TestUI/ProgressBarPage.xaml Outdated
@@ -27,12 +27,12 @@
<RowDefinition Height="*"/>
</Grid.RowDefinitions>

<StackPanel Grid.ColumnSpan="3" Orientation="Horizontal">
<StackPanel Grid.ColumnSpan="3" Orientation="Horizontal" Spacing="8">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing

Spacing is not available on RS2 which explains why all your tests are failing down level

@karkarl
Copy link
Contributor Author

karkarl commented Apr 30, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karkarl karkarl merged commit 7ef70d1 into main May 3, 2021
@karkarl karkarl deleted the user/karenlai/ProgressBarFix branch May 3, 2021 17:27
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Mar 14, 2024
@Kinnara
Port microsoft/microsoft-ui-xaml#4920
e8e38f8
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Mar 14, 2024
@Kinnara
Port microsoft/microsoft-ui-xaml#4920 (#663)
d98c634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters left review comments

@ranjeshj ranjeshj ranjeshj approved these changes

Assignees
No one assigned
Labels
area-Progress ProgressBar, ProgressRing area-UIDesign UI Design, styling team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karkarl @StephenLPeters @ranjeshj